meraki-analytics / orianna

A Java framework for the Riot Games League of Legends API (http://developer.riotgames.com/).
MIT License
182 stars 56 forks source link

IllegalArgumentException for Siege when calling RiotAPI.getStats(long id) #58

Closed jakewebber closed 7 years ago

jakewebber commented 7 years ago

I am only getting this exception with certain summoners (tried on summoner name "silent moon"). Could this be caused by not having any siege games?

java.lang.IllegalArgumentException: No enum constant com.robrua.orianna.type.core.stats.PlayerStatsSummaryType.Siege

at java.lang.Enum.valueOf(Unknown Source)
at com.robrua.orianna.type.core.stats.PlayerStatsSummaryType.valueOf(PlayerStatsSummaryType.java:3)
at com.robrua.orianna.api.core.StatsAPI.getStats(StatsAPI.java:97)
at com.robrua.orianna.api.core.RiotAPI.getStats(RiotAPI.java:1779)
robrua commented 7 years ago

Hey, just fixed this in an update. You can get the latest snapshot .jar @ robrua.com/orianna and it'll be in all future releases.

jakewebber commented 7 years ago

Just got the latest snapshot 4.2.5, getting a new IllegalArgumentException: No enum constant com.robrua.orianna.type.core.stats.PlayerStatsSummaryType.RankedPremade3x3

robrua commented 7 years ago

Huh... They removed that one from the docs so I assumed they wouldn't be sending it anymore. It's added back in now.

jakewebber commented 7 years ago

Thanks for being on top of all this since the season change!