meraki-analytics / orianna

A Java framework for the Riot Games League of Legends API (http://developer.riotgames.com/).
MIT License
182 stars 56 forks source link

Adding Initial UnitTests and Required Dependencies #93

Closed LeviMatus closed 5 years ago

LeviMatus commented 6 years ago

What does this feature do?

This feature adds Maven support for Junit5 and introduces a first series of unit tests for the Orianna abstract and sub classes.

Pom.xml

Motivation, context and linked issue

This is motivated by #75. I saw that there had been no work done on this, so I thought I'd add in a simple test suite so that anyone who wants to help out can just start writing tests and not worry about getting the configurations set up.

How has this been tested?

With unit tests!

You can execute the maven test task, or execute mvn test from your terminal.

Types of changes

Outstanding Work

robrua commented 5 years ago

Thanks for getting the process started on this, and sorry for taking so long to get around to merging it. We're back in action on development of Ori now, and hopefully this can help us get some much needed unit test contributions.

Thanks for the PR!