cloneprovision has vlan bugs

meraki / automation-scripts

MIT License

391 stars 198 forks source link

cloneprovision has vlan bugs #15

Closed cainh closed 4 years ago

cainh commented 4 years ago

When creating multiple networks from a single existing network, the script does not cater correctly for multiple entries in the input.csv file. The vlans are spread across all networks that you create.

mpapazog commented 4 years ago

Could you provide an example of an input file you have issues with, so I can test? Please change serial numbers into something meaningless before you send it.

cainh commented 4 years ago

Hi,

I have attached a debug showing the problem. The vlans list is not unique to each instance of retVal so it just gets added to the list of vlans. That list is populated across all instances of retVal. See attached screenshot. CSV file renamed to TXT so that I can upload here. netData.txt meraki script debug

mpapazog commented 4 years ago

Thank you for reporting this bug!

I found errors in class definitions, which were causing this issue. Could you please retest using the latest version of the script and let me know if it is now behaving as it should?

cainh commented 4 years ago

I've had a quick look at your code and it looks like it would sort the issues out. Unfortunately I will only be able to test this weekend. Will update you then.

cainh commented 4 years ago

All good now. Thanks for the quick fix.