Update the Go version from 1.19 to 1.20 as Go 1.19 will soon be no longer supported with Go 1.21 coming out in August
Remove the Terraform HTTP retry client (more below).
As library authors, we should strive to keep the library defaults as simple as possible, while maximizing the amount of configuration end-users can have.
By making the retry client the default HTTP client for the library, it would require us to expose the entire retry client's API surface, which shouldn't be our goal. Retry logic should be handled by the end user, and we can recommend to them that they use HashiCorp's retry library (which is what we at Starbucks have been using internally).
Fixes #5
Type of change
Please delete options that are not relevant.
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
How Has This Been Tested?
We've merged this change into our fork of the Terraform library and run our acceptance tests, and nothing seems to be of issue.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
Two main changes:
As library authors, we should strive to keep the library defaults as simple as possible, while maximizing the amount of configuration end-users can have.
By making the retry client the default HTTP client for the library, it would require us to expose the entire retry client's API surface, which shouldn't be our goal. Retry logic should be handled by the end user, and we can recommend to them that they use HashiCorp's retry library (which is what we at Starbucks have been using internally).
Fixes #5
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
We've merged this change into our fork of the Terraform library and run our acceptance tests, and nothing seems to be of issue.
Checklist: