New main branch SDK doesn't use the intended user agent string format

TKIPisalegacycipher commented 3 months ago

Prerequisites

[*] Have you tested the operation in the API directly? (Yes, this isn't an OAS issue)
[*] Do you have the latest SDK version? (Yes, this is a bug found in the code, not from using the library)
[*] Review compability matrix (no compatibility issue found)

Describe the bug In https://github.com/meraki/dashboard-api-go/blob/main/sdk/api_client.go, line 85 reads c.SetUserAgent("MerakiGolang/2.0.4 Cisco")

This UA string has a couple of issues.

Expected behavior

It should not have 'Cisco' in it (the equivalent Meraki Python SDK doesn't include 'Cisco' and we want to follow that pattern)
If the user doesn't supply any additional string, then it should be formatted go-meraki/{equivalent Meraki OAS revision number}, e.g. go-meraki/1.47.0
The library should allow a user to name their own application/provide their own string, such as ApplicationName VendorName (similar to the python SDK, see line 86 here and line 75 here)
It should include the user's self-defined UA string (e.g. ApplicationName VendorName) so that the full UA string submitted ends up following this format:

go-meraki/1.47.0 ApplicationName VendorName where 1.47.0 is the dashboard API revision for which the library is built

Screenshots N/A

Environment (please complete the following information): N/A

Thanks in advance for helping with this.

TKIPisalegacycipher commented 3 months ago

Note that the community version of the go SDK already uses and should continue to use golang-meraki/* to differentiate.

fmunozmiranda commented 3 months ago

UserAgent is now custom. And with format golang-meraki/* at default

TKIPisalegacycipher commented 3 months ago

And with format golang-meraki/* at default

This doesn't sound like the right solution, based on my report.

meraki / dashboard-api-go