search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
293 stars 154 forks source link

Changed if clause to catch all 2XX HTTP Codes #130

Closed deejaypro closed 3 years ago

deejaypro commented 3 years ago

Fixed #129 with catching all 2xx status codes inside if clause.

TKIPisalegacycipher commented 3 years ago

Hi @deejaypro -- a straightforward change but what was the scenario that led you to this?

deejaypro commented 3 years ago

Hey @TKIPisalegacycipher, i was working with the createNetworkWebhooksWebhookTest endpoint and it was always throwing an exception. createNetworkWebhooksWebhookTest returns a HTTP Code 201 Created which wasnt matching any condition in the if clause. This led to the exception raise in line 218.

TKIPisalegacycipher commented 3 years ago

Thank you!