search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
293 stars 154 forks source link

Change tag handling to support generation for Alpha API #153

Closed joshand closed 3 years ago

joshand commented 3 years ago

In the current build script, we are currently limiting to first 10 tags, which excluded environmental. I've expanded this to 11 in order to stop the crash. This might result in correct environmental APIs, but I've not actually tested this.

joshand commented 3 years ago

Re: meraki/api/batch/__init__.py

I had accidentally removed the meraki folder and had to restore it. When I did so, git converted the line breaks, so that's why this file is part of this commit.

warning: CRLF will be replaced by LF in meraki/api/batch/__init__.py. The file will have its original line endings in your working directory

TKIPisalegacycipher commented 3 years ago

Thank you for submitting this. I tested these changes, and it breaks library generation for GA. We will not make these changes for the time being.

joshand commented 3 years ago

To preserve library generation for GA/Beta branches, I moved this logic to an optional flag (-p ). So, to build for Alpha, you can use the following syntax: python3 generate_library.py -o 608548899648439349 -v 1 -p 11

Using the regular generation command will continue to operate as usual for GA/Beta builds. python3 generate_library.py -o 608548899648439349 -v 1

TKIPisalegacycipher commented 3 years ago

Thanks @joshand ! This is a step in the right direction. However, there are other parts (like action batches) which would require additional logic. We will undertake this effort when the MT team is ready to GA their endpoints. In the meantime, it's hard to justify the additional work and testing that would be required to integrate this into the main branch. These commits make more sense in a separate development branch. Would you like to open a devel branch?