search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
293 stars 154 forks source link

Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore #158

Closed Philippe-Ragon closed 3 years ago

Philippe-Ragon commented 3 years ago

I am making this call in one of my script: wireless.createNetworkWirelessSsidIdentityPsk(netID, ssidNumber, mapping['name'], mapping['passphrase'], policyID)

When I use package 1.7.2 it is working fine. With an upgrade to 1.10.0 I am getting the error message : createNetworkWirelessSsidIdentityPsk() takes 5 positional arguments but 6 were given

Downgrading to 1.7.2 solves the issue

TKIPisalegacycipher commented 3 years ago

Hi @Philippe-Ragon, one of the params on this endpoint has changed from required to optional. While not a breaking change for the API itself, I see how using positional arguments that would have resulted in this.

Just to confirm that this is the reason for the issue, please change your arguments to keyword arguments instead, and let me know if you continue to have the problem.

Philippe-Ragon commented 3 years ago

Hi John,

Could you please specify which arguments have to be changed from positional to keyword ? And could you please specify the keywords ?

Philippe Ragon +33 611 700 152

De : John M. Kuchta @.> Envoyé : jeudi 17 juin 2021 18:13 À : meraki/dashboard-api-python @.> Cc : Philippe RAGON @.>; Mention @.> Objet : Re: [meraki/dashboard-api-python] Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore (#158)

WARNING: This is an external email. Shall you have any doubt, report any suspicious e-mail by clicking on the "Report suspicious e-mail" button in Outlook.

Hi @Philippe-Ragonhttps://urldefense.com/v3/__https:/github.com/Philippe-Ragon__;!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFkCu4hpB$, one of the params on this endpoint has changed from required to optional. While not a breaking change for the API itself, I see how using positional arguments that would have resulted in this.

Just to confirm that this is the reason for the issue, please change your arguments to keyword arguments instead, and let me know if you continue to have the problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/meraki/dashboard-api-python/issues/158*issuecomment-863374056__;Iw!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFgGANQTw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AQ3ZRHZS6IK6WV7S73EN7ALTTINJ3ANCNFSM46346L6A__;!!Lt0KOR8!A65ZQKAIVHF3UJTERj_biw3QyccLFvPd6uvNktR6z5pOBi3df-A7Vd_xJd64W_1B0zelFp597BxK$.

TKIPisalegacycipher commented 3 years ago

For this test, change them all to keyword args. You would have to read the docs to see the names of the args though, that's outside the scope of an issue report.

Philippe-Ragon commented 3 years ago

The only doc I am aware of is the one online : https://developer.cisco.com/meraki/api-v1/#!create-network-wireless-ssid-identity-psk It is still referring to positional parameters. Looking at the code I found keywords for 3 parameters ==> I changed the call to the endpoint into wireless.createNetworkWirelessSsidIdentityPsk(netID, ssidNumber, name=mapping['name'], passphrase=mapping['passphrase'], groupPolicyId=policyID)

It is working with both package v1.7.2 and v1.10.0

Philippe Ragon +33 611 700 152

De : John M. Kuchta @.> Envoyé : jeudi 17 juin 2021 19:18 À : meraki/dashboard-api-python @.> Cc : Philippe RAGON @.>; Mention @.> Objet : Re: [meraki/dashboard-api-python] Upgrade from 1.7.2 to 1.10.0 - call to wireless.createNetworkWirelessSsidIdentityPsk() not working anymore (#158)

WARNING: This is an external email. Shall you have any doubt, report any suspicious e-mail by clicking on the "Report suspicious e-mail" button in Outlook.

For this test, change them all to keyword args. You would have to read the docs to see the names of the args though, that's outside the scope of an issue report.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/meraki/dashboard-api-python/issues/158*issuecomment-863419218__;Iw!!Lt0KOR8!DdBv0ZpaWrAcmW9uQ0ER-6xwsqmfVsozXuInBwJnjGHFdWGgt-RhNbdadj7EecgvO6FAomOEvRiz$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AQ3ZRH6UYK52T5SQOA2TYMDTTIU3LANCNFSM46346L6A__;!!Lt0KOR8!DdBv0ZpaWrAcmW9uQ0ER-6xwsqmfVsozXuInBwJnjGHFdWGgt-RhNbdadj7EecgvO6FAoiXgWgPW$.

TKIPisalegacycipher commented 3 years ago

Thank you for confirming!