search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
289 stars 151 forks source link

removes content-type check for json #181

Closed coreGreenberet closed 2 years ago

coreGreenberet commented 2 years ago

workaround for #177

TKIPisalegacycipher commented 2 years ago

Let's hold on this until dust settles on server-side fixes.

TKIPisalegacycipher commented 2 years ago

We can expect application/json content types for endpoints that return JSON content; this excepts any endpoint responding with a 204 No Content.

Given this, would you want to modify your PR in any way?

coreGreenberet commented 2 years ago

I think we should keep the PR like it is for 3 reasons:

1) The behaviour is then same as the request based version 2) There is no need for additional checks like 204 as the .json() method will handle that 3) If the backend creates a similiar issue again, we won't have troubles in the library