search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
292 stars 152 forks source link

allow verbose parameter on getNetworkEvents #204

Closed bk2zsto closed 1 year ago

bk2zsto commented 1 year ago

In Meraki Case # 09285978 I was advised to add verbose=True to my getNetworkEvents call in order to get aid included in association events. It is appended to the event in the extraData key.

Its not documented in the OpenAPI spec but I'd like to get rid of my local fork for making this work. If I need to fork the OpenAPI repo and add it there I can do that too.

Guessing verbose is available for lots of other methods but not sure where to start determining that.

andy-shady-org commented 1 year ago

This MR removes the patch that was applied for request exceptions what was fixed in https://github.com/meraki/dashboard-api-python/pull/202

TKIPisalegacycipher commented 1 year ago

Hi @bk2zsto we've long made the strategic decision to not complicate this library by hacking undocumented attributes or parameters into the library. If you would like to see it added here, please reach out to Meraki Support and/or your account rep and open a feature request.

If Meraki chooses to officially document this attribute, then the subsequent library release will include it.

Thank you @andy-shady-org as well for calling out the reversion of #202.

For now, I will close this PR.