meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
287 stars 149 forks source link

claimNetworkDevices with addAtomically fails with unexpected keyword argument #261

Open rasmusbirkelund opened 1 month ago

rasmusbirkelund commented 1 month ago

Using the meraki package, installed using pip, when assigning devices to a network, and setting the keyword addAtomically to true, the call fails with unexpceted keyword error.

According to API documentation on meraki.io, this is an optional parameter, although it is not listed in the API schema. https://developer.cisco.com/meraki/api-v1/claim-network-devices/

billede

I'm calling the function in my script as such, response = dashboard.networks.claimNetworkDevices( NetworkId, SerialsToAssign, addAtomically=True ) print(response)

(.venv) RHB@wopr AddDevicesToNetwork % pip show meraki Name: meraki Version: 1.46.0 Summary: Cisco Meraki Dashboard API library Home-page: https://github.com/meraki/dashboard-api-python Author: Cisco Meraki Author-email: api-feedback@meraki.net License: MIT Location: /Users/RHB/Documents/dev-local/.../AddDevicesToNetwork/.venv/lib/python3.12/site-packages Requires: aiohttp, requests Required-by: (.venv) RHB@wopr AddDevicesToNetwork % (.venv) RHB@wopr AddDevicesToNetwork % python -V Python 3.12.4 (.venv) RHB@wopr AddDevicesToNetwork %

TKIPisalegacycipher commented 1 month ago

Hello @rasmusbirkelund thank you for reporting this. I believe this is fixed in 1.48.0 of the library. Would you mind updating your library and testing to confirm? Thank you kindly.