search

meraki / dashboard-api-python

Official Dashboard API library (SDK) for Python
MIT License
293 stars 154 forks source link

Do not distribute tests #269

Open spt29 opened 2 weeks ago

spt29 commented 2 weeks ago

The wheel built for this project contains a tests package, which should definitely not be distributed: Its name is very generic, clashes easily with other (local) packages of the same name, leading to obscure and hard-to-find bugs. This is probably just an oversight and easily fixed in setup.py by using

packages=find_packages(exclude=["tests"]),

instead of

packages=find_packages(),
TKIPisalegacycipher commented 2 weeks ago

Hi @spt29 thanks for reporting this. If you like, please submit a PR that resolves this issue and I'd be happy to review and mainline it.

spt29 commented 1 week ago

Done (with my personal account)