search

meraymond2 / idris-vscode

Idris front-end for VS Code
MIT License
59 stars 10 forks source link

Pass 0 console width explicitly to idris proc #30

Closed meraymond2 closed 3 years ago

meraymond2 commented 3 years ago

Workaround to solve one of the issues described here: https://github.com/meraymond2/idris-vscode/issues/23.

The Idris IDE process inserts new lines into replies based on the width of the terminal, presumably because it's using the same code as the Idris REPL. When it's not running inside a terminal, it should infer the width as 0, and not do any wrapping. On some systems, it seems like it's inferring this incorrectly, and it tries to wrap after every word.

Passing the console width in explicitly fixes this for now, until the fix is merged and released.

michaelmesser commented 3 years ago

I don't think this is needed. Console width detection was added after the last released version and I imagine it will be fixed before the next release. I have to make one change to reduce duplicate code, but then I anticipate that my PR will be merged within a few days at most.

meraymond2 commented 3 years ago

Ah, I thought it was introduced in 0.2.1, and wanted to make it sure it wouldn't come up for anyone else. I can this change out again in the next release, I assume most people will either be on 0.2.1, or the master branch. In the meantime, it might be superfluous, but it's not doing any harm.

michaelmesser commented 3 years ago

My PR was merged so it is safe to remove this in the next release.