merbanan / rtl_433

Program to decode radio transmissions from devices on the ISM bands (and other frequencies)
GNU General Public License v2.0
6.16k stars 1.33k forks source link

Terminal output ignores terminal capabilities (termcap). #2824

Closed dreirund closed 9 months ago

dreirund commented 9 months ago

When I run TERM=dump rtl_443 --help, there should be no colouring at all, since dump terminals do not support this.

But there still is coloured output, see screenshot below.

Please consider making coloured output according to the terminal capabilities, preferably using the termcap library.

Regards!


rtl_433--help_colouroutput


zuckschwerdt commented 9 months ago

We won't link to external libs like e.g. termcap. If there is another way to cheaply accomplish this please advice. For now this is not a todo for us.

dreirund commented 9 months ago

We won't link to external libs like e.g. termcap. If there is another way to cheaply accomplish this please advice. For now this is not a todo for us.

OK. But then this would break in some cases, e.g. also some serial terminals.

Maybe you then add a command line option like -nc | --no-colour?

Regards!

zuckschwerdt commented 9 months ago

This should be addressed by 0443488 now. RTL433_COLOR=always/never/auto Can you check if it works for you?