merbin2012 / sharex

Automatically exported from code.google.com/p/sharex
0 stars 1 forks source link

"Stop upload" does not stop the upload immediatelly #373

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When you right-click any ongoing upload and then click "Stop upload", nothing 
happens after several seconds (or even minutes), at least with Picasa.

What version of the product are you using? On what operating system?
ShareX 7.1.1.390 on Windows 7 Pro x64

Original issue reported on code.google.com by neik...@gmail.com on 5 Jun 2013 at 12:12

GoogleCodeExporter commented 9 years ago
How stop upload button working is, uploading bytes in loop and if stop upload 
button is pressed, in this loop i can break/return it. But if request function 
stuck while sending and not receiving any response then it can't reach to my 
check about is stop button pressed so i can't stop it. Mainly softwares 
handling this with thread killing but i can't kill my thread because it must 
handle some jobs after failed upload. So it is technical problem :(
So if upload is happening properly then it can stop instantly but if it is 
stuck while sending request then it can't reach to my if check for stop it.

Original comment by flexy...@gmail.com on 5 Jun 2013 at 4:54

GoogleCodeExporter commented 9 years ago
Issue 374 has been merged into this issue.

Original comment by flexy...@gmail.com on 5 Jun 2013 at 4:55

GoogleCodeExporter commented 9 years ago
Most important problem is be able to test this because i must find host which 
get stuck when sending request so i can test this stop upload.

Original comment by flexy...@gmail.com on 13 Jun 2013 at 3:03

GoogleCodeExporter commented 9 years ago
You will need something to throttle your Internet connection.

Original comment by neik...@gmail.com on 13 Jun 2013 at 9:22

GoogleCodeExporter commented 9 years ago
I don't like to kill thread just because .NET httprequest class not support non 
async aborting. It can cause problems which i can't predict because i don't 
know whats going on inside httprequest class and i can't test this situation. 
Only time it is not instant when remote host not responding and you can't 
accidentally upload when it is not responding anyway so i will leave how it is 
now.
So i don't know proper solution to this problem and i don't want to make it 
worse. Because even it is not instant still it properly stopping after timeout.

Original comment by flexy...@gmail.com on 23 Jun 2013 at 6:44

GoogleCodeExporter commented 9 years ago
OK, but even if you don't kill that thread, at least show the upload as 
"Stopped" immediatelly, or something like "Stopping", so the user knows that 
its action has been understood by the program.

Original comment by neik...@gmail.com on 23 Jun 2013 at 3:09

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r424.

Original comment by flexy...@gmail.com on 25 Jun 2013 at 6:02