merbin2012 / sharex

Automatically exported from code.google.com/p/sharex
0 stars 1 forks source link

Rectangle selection shadow causes a lot of lag when using a lot of monitors #453

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Hookup six monitors
2. Attempt to take a rectangular selection

What is the expected output? What do you see instead?
I'm looking for a way to disable the fullscreen shadow, but I cannot find such 
an option (I don't like it at all).  Plus the shadow is very laggy.

What version of the product are you using? On what operating system?
8.1.0 r573 - Windows 7 Enterprise x64

Please provide any additional information below.
1. Add option to disable shadow (and make the options more clear if it is 
already an option).
2. Perhaps include a list of hotkeys within the program rather than solely on 
the wiki.

Original issue reported on code.google.com by grantsk...@gmail.com on 5 Sep 2013 at 3:08

GoogleCodeExporter commented 9 years ago
I should probably clarify by how laggy.  I'm essentially getting 3-10 fps when 
I try to select an area or move the mouse cursor.

It may be the shadow it puts everywhere or something else 
underlying/non-visual.  I know the cursor lines put a HUGE performance hit (but 
I would like to have those on if they didn't cause such issue).  I'm guessing 
just from the fact it draws a line so large it starts to panic.

--

It draws a line all the way from left most left screen to rightmost right 
screen. That's a lot of pixels to account for.  I'm not sure if the black space 
(where there is no screen) is also drawn behind-the-scenes or not.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago
Look like you have to download the image to view it properly.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 8:29

GoogleCodeExporter commented 9 years ago
All screen image will redraw everytime which is very big image that causing 
performance issue.

Original comment by flexy...@gmail.com on 5 Sep 2013 at 8:30

GoogleCodeExporter commented 9 years ago
I also made light rectangle region thing before you can try it if you want but 
i need to add setting for it.

Original comment by flexy...@gmail.com on 5 Sep 2013 at 8:43

GoogleCodeExporter commented 9 years ago
So are you want me to make setup file so you can try it?

Original comment by flexy...@gmail.com on 5 Sep 2013 at 9:28

GoogleCodeExporter commented 9 years ago
I will be willing to try it.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 9:56

GoogleCodeExporter commented 9 years ago
https://dl.dropbox.com/u/14076298/ShareX/2013/09/ShareX-8.1.0.575-setup.exe
How to use it: https://dl.dropbox.com/u/14076298/ShareX/2013/09/skVbttRjgH.png

Original comment by flexy...@gmail.com on 5 Sep 2013 at 9:59

GoogleCodeExporter commented 9 years ago
That made ShareX unusable.  The top left corner of the 'frozen image' was 
aligned with my main monitor so the whole image was greatly offset.

Much better performance out of it, but unusable.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 10:57

GoogleCodeExporter commented 9 years ago
I don't have multi monitor so i can't test but is region selection screen have 
problem or after select it getting wrong image?

Original comment by flexy...@gmail.com on 5 Sep 2013 at 10:59

GoogleCodeExporter commented 9 years ago
I think that window position is wrong, can you compile project yourself if i 
commit it to svn?

Original comment by flexy...@gmail.com on 5 Sep 2013 at 11:06

GoogleCodeExporter commented 9 years ago
After I hit the hotkey for region selection, this is when the whole images 
becomes askew.

Image would explain better than words. The white line is to indicate the full 
with of my main screen.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 11:09

Attachments:

GoogleCodeExporter commented 9 years ago
Had to re-up image due to personal information.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 11:15

Attachments:

GoogleCodeExporter commented 9 years ago
If you told me how I'm sure I could compile it myself.  Haven't had any 
experience with svn stuffs.

Original comment by grantsk...@gmail.com on 5 Sep 2013 at 11:49

GoogleCodeExporter commented 9 years ago
Can you try this: 
https://dl.dropbox.com/u/14076298/ShareX/2013/09/ShareX-8.1.0.575-setup.exe

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:01

GoogleCodeExporter commented 9 years ago
Now everything screenshotted is now grey, alignment is still the same.

The performance for the selection is great though. (albeit I cannot select 
anything useful)

I can actually screenshot stuff that is NOT the grey portion.  So if you rid of 
that it would be perfect.

--

Nevermind on that, it stopped taking snapshots now (I only got one screenshot 
working). For region selection only.  Full screenshot works as expected.

Original comment by grantsk...@gmail.com on 6 Sep 2013 at 12:16

Attachments:

GoogleCodeExporter commented 9 years ago
So annoying to do multi monitor stuff without have multi monitor :(

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:18

GoogleCodeExporter commented 9 years ago
I believe it.

Maybe just have an option to disable the shadow drawing but maintain the normal 
region selection process?  So the only thing it does is give you the little 
crosshair.

I'm not sure how you have it setup though.  Does it essentially take a 
fullscreen snapshot then overlay that over the visible area?

Would it be possible to have the region select be running over a 'live' 
environment, so you select an area while the desktop environment is still 
active?  I hope that makes sense.

Or is it based on a screenshot then select later type of method?

Original comment by grantsk...@gmail.com on 6 Sep 2013 at 12:25

GoogleCodeExporter commented 9 years ago
Actually disabling shadow won't change any performance because i was doing 
there trick instead draw actual screenshot to screen saving shadowed screenshot 
as image and drawing them so it is same speed as drawing non shadowed one.

I tried your live environment thing and noticed actually windows drawing 
background automatically in background for it to be act like transparent so it 
not speed up anything.

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:31

GoogleCodeExporter commented 9 years ago
ooooooooo

Since windows is drawing live.  Can you have ShareX only draw the cursor and 
the bounded region?  Or to do so do you have to draw a full 
transparent/nonstransparent background in order to draw the cursor/box?

I guess you can now make an option to 'capture region live' :D

Original comment by grantsk...@gmail.com on 6 Sep 2013 at 12:36

GoogleCodeExporter commented 9 years ago
https://dl.dropbox.com/u/14076298/ShareX/2013/09/ShareX-8.1.0.575-setup.exe now 
must be fixed.

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:47

GoogleCodeExporter commented 9 years ago
http://i.imgur.com/s230Vz5.png
I agree!

Perfect now, everything is working as intended, and the performance issue is 
now squashed.

Great job.

--

Unrelated (make new thread?):
After all those installs, is there a way to keep your settings as far as 
authorization for file hosts? Because I had to set that up each time.

Original comment by grantsk...@gmail.com on 6 Sep 2013 at 12:55

GoogleCodeExporter commented 9 years ago
Your settings not supposed to reset in these installs i sent to you. Especially 
uploaders config not touched long time so it should never reset.

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:58

GoogleCodeExporter commented 9 years ago

Original comment by flexy...@gmail.com on 6 Sep 2013 at 12:58

GoogleCodeExporter commented 9 years ago
nm, on a second glance it may have. I don't think I actually looked that far 
down for the imgur one.  The authorization for dropbox and google drive were 
still good. My bad.

Thanks again.

Original comment by grantsk...@gmail.com on 6 Sep 2013 at 1:00

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r576.

Original comment by flexy...@gmail.com on 6 Sep 2013 at 1:28

GoogleCodeExporter commented 9 years ago
Can you test this build: 
https://dl.dropbox.com/u/14076298/ShareX/2013/09/ShareX-8.2.0.648-setup.exe

I did some performance improvements to default shape capture and it must be 
much faster now.

Original comment by flexy...@gmail.com on 23 Sep 2013 at 12:50

GoogleCodeExporter commented 9 years ago
Wow, the new default option (light rectangle selection false) is quite silky 
smooth now, even better than light rectangle selection.

Only thing, the crosshairs/magnifier off does not persist between selections, 
with these enabled the lag returns.

--

Also, I have been having some black screen selection issues, I probably should 
make a new thread for this.  When I take a window screenshot or selection. The 
window or go to select an area, everything is black.  I have to change the 
transparency setting to the opposite for it to fix. (enabled to disabled, or 
disabled to enabled depending on it's current state.

Original comment by grantsk...@gmail.com on 23 Sep 2013 at 1:18

GoogleCodeExporter commented 9 years ago
Changing crosshair etc. setting with hotkey not supposed to be persist now, 
because of technical reasons to do with new hotkey system.
You should change them from Task settings window.

I also added Show FPS setting there by the way. Is crosshair really affecting 
fps? I think it shouldn't.

I don't understand what black screen selection issues you have.

Original comment by flexy...@gmail.com on 23 Sep 2013 at 1:24

GoogleCodeExporter commented 9 years ago
I get around 9-11 fps with both crosshairs disabled or enabled. However, the 
crosshairs have at least a .5 second delay behind the cursor.  It is negligible 
on two or less monitors, but with all 6 the performance tanks really bad.

I'll create a new thread for the black screen issue.

Original comment by grantsk...@gmail.com on 23 Sep 2013 at 1:32

GoogleCodeExporter commented 9 years ago
Crosshair is not doing drawing it is Windows cursor therefore it won't have any 
lag.
Drawing 6x monitor screenshot to screen every frame will be very slow :(
Mainly i'm getting 100-150 fps. Without use directx i don't know how can i make 
it faster.

Original comment by flexy...@gmail.com on 23 Sep 2013 at 1:37

GoogleCodeExporter commented 9 years ago
I mean crosshair cursor.

Original comment by flexy...@gmail.com on 23 Sep 2013 at 1:38

GoogleCodeExporter commented 9 years ago
The lines generated off the crosshairs are the source of the lag, not the 
crosshair cursor itself.

The 'screen wide crosshair' thing.

Original comment by grantsk...@gmail.com on 23 Sep 2013 at 1:47