ChicoUI - .number validation is not validating floats

mercadolibre / chico

A collection of easy-to-use UI components.

http://chico.mercadolibre.com

MIT License

343 stars 87 forks source link

Closed guillermosnipeml closed 7 years ago

guillermosnipeml commented 10 years ago

.number won´t validate values like "12,34", or "12.34" due that the regexp only matches integers discarding the value datatype.

Proposed solution:

force coertion to number like this: +"12,34", and then ask for the returned result with isNaN, if true, the coertion failed, if false it's a number now.
Keep in mind that as the result of forcing the coertion to number "-12.34" will become a valid number too. (-12.34)

battaglr commented 7 years ago

Sadly I'll have to close this since it's not aligned with the project's current objectives. :pensive:

Thanks for opening the issue. :grinning: