mercadolibre / chico

A collection of easy-to-use UI components.
http://chico.mercadolibre.com
MIT License
342 stars 91 forks source link

Is the `padding` in the `body` really necessary? #1224

Closed battaglr closed 9 years ago

battaglr commented 9 years ago

In shared/reset.css que can see the following:

body {
  padding: 0 10px; /* Prevent layout "sticking" to the edge of the browser */
}

I don't quite get why Chico should assign a padding to the body —every browsers sets a default of 0. Why is "prevent layout 'sticking' to the edge of the browser" a bad thing that we need to prevent with that line?

hmammana commented 9 years ago

The design team had defined it for MercadoLibre in that way.

battaglr commented 9 years ago

Good point.

How do you feel about creating a label like "Reconsider in v3" –or something like that–, so we can quickly filter the issues that doesn't apply right know, but we don't want to loose track of since might be useful in the future. This also may help with other issues that we are not sure to close for the same reason. Just a thought.


As we talked offline, and at the time I didn't have enough use-cases where this rule was being overridden. I'll be updating this comment with cases from different projects.

.body-full  {
    /* ... */
    padding: 0;
    /* ... */
}