mercadolibre / chico

A collection of easy-to-use UI components.
http://chico.mercadolibre.com
MIT License
343 stars 87 forks source link

Carousel - Pagination parameter is obsolete #1241

Closed tauchter closed 9 years ago

tauchter commented 9 years ago

Even the pagination parameter is defaulted to false the pagination gets rendered anyways. The probable cause its that on the plugin initialisation the following assertion is not done:

this._options.pagination !== false

Same thing its happening on the _updatePages function

atma commented 9 years ago

Instead of adding an additional checks where the exact value is not important better to use truthy/falsy values. In this case should be if (this._options.pagination) { this._addPagination(); }.

tauchter commented 9 years ago

I am on it, the PR is on the way.

tauchter commented 9 years ago

@atma Feel free to check the PR https://github.com/mercadolibre/chico/pull/1242 and make any necessary comment of what can be improved.