Closed tauchter closed 9 years ago
Instead of adding an additional checks where the exact value is not important better to use truthy/falsy values. In this case should be if (this._options.pagination) { this._addPagination(); }
.
I am on it, the PR is on the way.
@atma Feel free to check the PR https://github.com/mercadolibre/chico/pull/1242 and make any necessary comment of what can be improved.
Even the pagination parameter is defaulted to false the pagination gets rendered anyways. The probable cause its that on the plugin initialisation the following assertion is not done:
Same thing its happening on the _updatePages function