search

mercadolibre / chico

A collection of easy-to-use UI components.
http://chico.mercadolibre.com
MIT License
342 stars 91 forks source link

offsetY and offsetX in Validations are useless? #1318

Closed escudero89 closed 8 years ago

escudero89 commented 8 years ago

Could it be that those values are not affecting the target at all? I tried looking up in the source code, but I couldn't see a place where those values are actually being used.

I could be incredible wrong though, so I apologize myself in advance.

Greetings.

battaglr commented 8 years ago

@escudero89, which version are you using?

escudero89 commented 8 years ago

Chico 2.0.3, and the looking up of the source code was donde over the master branch.

battaglr commented 8 years ago

@escudero89, if I'm not mistaken the way in which we handle the validation messages was modified in v2x. Let's invite @atma to the conversation. :grinning:

atma commented 8 years ago

@escudero89 Validation is extends the Bubble which extends the Popover that uses Positioner for its positioning, so offsetY and offsetX are passing to that component trough this complex chain. Do you have some troubles with the positioning of validator's messages?

escudero89 commented 8 years ago

To be honest, I wasn't so sure what was offsetY actually changing, due that we use a version of Chico Mobile in which the validations doesn't have bubbles. At least for me the docs are quite confusing about what this target is in the description of offset(X/Y).

I tried to understand how the offset was being used, and since I didn't notice a change in our validations nor I'd found how it was being used in master, I reported this issue.

It can be closed now.

atma commented 8 years ago

@escudero89 Thank you for the explanation.