search

mercari / datastore

(AE|Cloud) Datastore Wrapper
MIT License
214 stars 20 forks source link

dsmiddleware/rpcretry: Should not retry code=Aborted and code=InvalidArgument #90

Closed apstndb closed 2 years ago

apstndb commented 2 years ago

In current implementation of dsmiddleware/rpcretry, 

code = Aborted desc = too much contention on these datastore entities. please try again. entity group key: ...

is retried and repeat

code = InvalidArgument desc = The referenced transaction has expired or is no longer valid.

They should not be retried.

apstndb commented 2 years ago

Official Documentation: Errors and Error Handling https://cloud.google.com/datastore/docs/concepts/errors?hl=en#error_codes