search

mercari / grpc-federation

gRPC Federation generates a gRPC server by writing a custom option in Protocol Buffers
MIT License
318 stars 13 forks source link

Change plugin schema #203

Closed goccy closed 5 months ago

goccy commented 5 months ago

Considering future extensibility, I defined a file option and linked the plugin definition to it. Additionally, instead of using strings for type definitions, I made it possible to specify them in the same way as the Env case.

github-actions[bot] commented 5 months ago

Code Metrics Report

main (77287d0) #203 (e36f6aa) +/-
Coverage 65.1% 65.0% -0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 6m57s 7m13s +16s
Details ``` diff | | main (77287d0) | #203 (e36f6aa) | +/- | |---------------------|----------------|----------------|-------| - | Coverage | 65.1% | 65.0% | -0.1% | | Files | 69 | 69 | 0 | | Lines | 11448 | 11473 | +25 | | Covered | 7457 | 7457 | 0 | - | Code to Test Ratio | 1:0.3 | 1:0.3 | -0.0 | | Code | 36474 | 36515 | +41 | | Test | 12567 | 12567 | 0 | - | Test Execution Time | 6m57s | 7m13s | +16s | ```

Code coverage of files in pull request scope (81.0% → 80.4%)

Files Coverage +/-
generator/code_generator.go 79.6% 0.0%
grpc/federation/alias.go 0.0% 0.0%
resolver/resolver.go 81.1% -1.1%

Reported by octocov