search

mercari / grpc-federation

gRPC Federation generates a gRPC server by writing a custom option in Protocol Buffers
MIT License
318 stars 13 forks source link

Fix error log #208

Closed utahta closed 4 months ago

utahta commented 4 months ago

Output log attributes defined in proto (using grpc.federation.log.add) when validation and gRPC call errors.

github-actions[bot] commented 4 months ago

Code Metrics Report

main (486ee6c) #208 (d83bbc3) +/-
Coverage 65.0% 64.8% -0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 7m0s 7m19s +19s
Details ``` diff | | main (486ee6c) | #208 (d83bbc3) | +/- | |---------------------|----------------|----------------|-------| - | Coverage | 65.0% | 64.8% | -0.1% | | Files | 69 | 69 | 0 | | Lines | 11574 | 11605 | +31 | + | Covered | 7522 | 7525 | +3 | - | Code to Test Ratio | 1:0.3 | 1:0.3 | -0.0 | | Code | 36758 | 36818 | +60 | | Test | 12567 | 12567 | 0 | - | Test Execution Time | 7m0s | 7m19s | +19s | ```

Code coverage of files in pull request scope (56.5% → 46.0%)

Files Coverage +/-
grpc/federation/cel/log.go 100.0% 0.0%
grpc/federation/context.go 0.0% 0.0%
grpc/federation/error.go 0.0% 0.0%
grpc/federation/log/context.go 51.5% -35.2%

Reported by octocov

github-actions[bot] commented 4 months ago

Code Metrics Report

main (486ee6c) #208 (1ea09ce) +/-
Coverage 65.0% 64.8% -0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 7m0s 6m57s -3s
Details ``` diff | | main (486ee6c) | #208 (1ea09ce) | +/- | |---------------------|----------------|----------------|-------| - | Coverage | 65.0% | 64.8% | -0.1% | | Files | 69 | 69 | 0 | | Lines | 11574 | 11605 | +31 | + | Covered | 7522 | 7525 | +3 | - | Code to Test Ratio | 1:0.3 | 1:0.3 | -0.0 | | Code | 36758 | 36818 | +60 | | Test | 12567 | 12567 | 0 | + | Test Execution Time | 7m0s | 6m57s | -3s | ```

Code coverage of files in pull request scope (56.5% → 46.0%)

Files Coverage +/-
grpc/federation/cel/log.go 100.0% 0.0%
grpc/federation/context.go 0.0% 0.0%
grpc/federation/error.go 0.0% 0.0%
grpc/federation/log/context.go 51.5% -35.2%

Reported by octocov

github-actions[bot] commented 4 months ago

Code Metrics Report

main (486ee6c) #208 (997748c) +/-
Coverage 65.0% 64.9% -0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 7m0s 7m14s +14s
Details ``` diff | | main (486ee6c) | #208 (997748c) | +/- | |---------------------|----------------|----------------|-------| - | Coverage | 65.0% | 64.9% | -0.1% | | Files | 69 | 69 | 0 | | Lines | 11574 | 11603 | +29 | + | Covered | 7522 | 7525 | +3 | - | Code to Test Ratio | 1:0.3 | 1:0.3 | -0.0 | | Code | 36758 | 36815 | +57 | | Test | 12567 | 12567 | 0 | - | Test Execution Time | 7m0s | 7m14s | +14s | ```

Code coverage of files in pull request scope (56.5% → 46.7%)

Files Coverage +/-
grpc/federation/cel/log.go 100.0% 0.0%
grpc/federation/context.go 0.0% 0.0%
grpc/federation/error.go 0.0% 0.0%
grpc/federation/log/context.go 51.5% -35.2%

Reported by octocov