Pass context.Context to CEL function

goccy commented 3 months ago

Use CEL Macros to pass context.Context argument to CEL function
- e.g.) pkg.func(arg) => pkg.func(grpc.federation.private.Context, arg)
Use singleton instance for all CEL libraries
- Remove UseContextLibrary flag
- wasm plugins are initialized at constructor

github-actions[bot] commented 3 months ago

Code Metrics Report

	main (ca04ccb)	#225 (5430641)	+/-
Coverage	65.2%	65.4%	+0.2%
Code to Test Ratio	1:0.3	1:0.4	+0.0
Test Execution Time	7m11s	7m10s	-1s

Details

``` diff | | main (ca04ccb) | #225 (5430641) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.2% | 65.4% | +0.2% | | Files | 69 | 71 | +2 | | Lines | 11803 | 11722 | -81 | - | Covered | 7691 | 7667 | -24 | + | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 | | Code | 37192 | 36619 | -573 | + | Test | 12668 | 12836 | +168 | + | Test Execution Time | 7m11s | 7m10s | -1s | ```

Code coverage of files in pull request scope (70.8% → 71.5%)

Files	Coverage	+/-
generator/code_generator.go	79.4%	+0.1%
grpc/federation/cel.go	0.0%	0.0%
grpc/federation/cel/bind.go	93.9%	+93.9%
grpc/federation/cel/context.go	33.3%	+33.3%
grpc/federation/cel/lib.go	100.0%	+12.0%
grpc/federation/cel/log.go	100.0%	0.0%
grpc/federation/cel/metadata.go	100.0%	0.0%
grpc/federation/cel/plugin.go	0.0%	0.0%
grpc/federation/cel/rand.go	65.0%	+1.8%
grpc/federation/cel/time.go	77.3%	+0.2%
grpc/federation/cel/uuid.go	73.3%	+1.9%
grpc/federation/lib.go	0.0%	0.0%
grpc/federation/validation.go	0.0%	0.0%
resolver/def.go	94.1%	+7.0%
resolver/message.go	74.9%	-0.0%
resolver/resolver.go	81.9%	+0.1%
resolver/types.go	86.7%	0.0%
resolver/value.go	78.8%	+1.0%

Reported by octocov

github-actions[bot] commented 3 months ago

Code Metrics Report

	main (ca04ccb)	#225 (3bdadad)	+/-
Coverage	65.2%	65.4%	+0.3%
Code to Test Ratio	1:0.3	1:0.4	+0.0
Test Execution Time	7m11s	7m2s	-9s

Details

``` diff | | main (ca04ccb) | #225 (3bdadad) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.2% | 65.4% | +0.3% | | Files | 69 | 71 | +2 | | Lines | 11803 | 11716 | -87 | - | Covered | 7691 | 7667 | -24 | + | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 | | Code | 37192 | 36605 | -587 | + | Test | 12668 | 12836 | +168 | + | Test Execution Time | 7m11s | 7m2s | -9s | ```

Code coverage of files in pull request scope (70.8% → 71.6%)

Files	Coverage	+/-
generator/code_generator.go	79.4%	+0.1%
grpc/federation/cel.go	0.0%	0.0%
grpc/federation/cel/bind.go	93.9%	+93.9%
grpc/federation/cel/context.go	33.3%	+33.3%
grpc/federation/cel/lib.go	100.0%	+12.0%
grpc/federation/cel/log.go	100.0%	0.0%
grpc/federation/cel/metadata.go	100.0%	0.0%
grpc/federation/cel/plugin.go	0.0%	0.0%
grpc/federation/cel/rand.go	65.0%	+1.8%
grpc/federation/cel/time.go	77.3%	+0.2%
grpc/federation/cel/uuid.go	73.3%	+1.9%
grpc/federation/lib.go	0.0%	0.0%
grpc/federation/validation.go	0.0%	0.0%
resolver/def.go	94.1%	+7.0%
resolver/message.go	74.9%	-0.0%
resolver/resolver.go	81.9%	+0.1%
resolver/types.go	86.7%	0.0%
resolver/value.go	78.8%	+1.0%

Reported by octocov

shuheiktgw commented 3 months ago

IIUC, this field should be removed as well?

github-actions[bot] commented 3 months ago

Code Metrics Report

	main (c1c2907)	#225 (1288f42)	+/-
Coverage	65.2%	65.4%	+0.3%
Code to Test Ratio	1:0.3	1:0.4	+0.0
Test Execution Time	7m1s	7m2s	+1s

Details

``` diff | | main (c1c2907) | #225 (1288f42) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.2% | 65.4% | +0.3% | | Files | 69 | 71 | +2 | | Lines | 11803 | 11718 | -85 | - | Covered | 7691 | 7669 | -22 | + | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 | | Code | 37192 | 36608 | -584 | + | Test | 12668 | 12836 | +168 | - | Test Execution Time | 7m1s | 7m2s | +1s | ```

Code coverage of files in pull request scope (70.5% → 71.3%)

Files	Coverage	+/-
generator/code_generator.go	79.4%	+0.1%
grpc/federation/cel.go	0.0%	0.0%
grpc/federation/cel/bind.go	93.9%	+93.9%
grpc/federation/cel/context.go	33.3%	+33.3%
grpc/federation/cel/enum.go	51.9%	+1.3%
grpc/federation/cel/lib.go	100.0%	+12.0%
grpc/federation/cel/log.go	100.0%	0.0%
grpc/federation/cel/metadata.go	100.0%	0.0%
grpc/federation/cel/plugin.go	0.0%	0.0%
grpc/federation/cel/rand.go	65.0%	+1.8%
grpc/federation/cel/time.go	77.3%	+0.2%
grpc/federation/cel/uuid.go	73.3%	+1.9%
grpc/federation/lib.go	0.0%	0.0%
grpc/federation/validation.go	0.0%	0.0%
resolver/def.go	94.1%	+7.0%
resolver/message.go	74.9%	-0.0%
resolver/resolver.go	81.9%	+0.1%
resolver/types.go	86.7%	0.0%
resolver/value.go	78.8%	+1.0%

Reported by octocov

mercari / grpc-federation