Fix validation for alias

mercari / grpc-federation

gRPC Federation generates a gRPC server by writing a custom option in Protocol Buffers

MIT License

318 stars 13 forks source link

Fix validation for alias #233

Closed goccy closed 3 months ago

goccy commented 3 months ago

The following definition make map between pkg.M and dep.M. But currently, in the field binding, pkg.M value cannot assign to dep.M field. ( however, dep.M value can assign to pkg.M field )

package pkg;

message M {
  option (grpc.federation.message).alias = "dep.M";
}

github-actions[bot] commented 3 months ago

Code Metrics Report

	main (739457f)	#233 (7d2598c)	+/-
Coverage	65.6%	65.5%	-0.0%
Code to Test Ratio	1:0.3	1:0.3	+0.0
Test Execution Time	7m3s	6m58s	-5s

Details

``` diff | | main (739457f) | #233 (7d2598c) | +/- | |---------------------|----------------|----------------|-------| - | Coverage | 65.6% | 65.5% | -0.0% | | Files | 71 | 71 | 0 | | Lines | 11831 | 11825 | -6 | - | Covered | 7756 | 7747 | -9 | + | Code to Test Ratio | 1:0.3 | 1:0.3 | +0.0 | | Code | 37100 | 37064 | -36 | + | Test | 12890 | 12892 | +2 | + | Test Execution Time | 7m3s | 6m58s | -5s | ```

Code coverage of files in pull request scope (82.1% → 82.3%)

Files	Coverage	+/-
resolver/resolver.go	82.3%	+0.2%

Reported by octocov