mercari / grpc-federation

gRPC Federation generates a gRPC server by writing a custom option in Protocol Buffers
MIT License
318 stars 13 forks source link

Support URL CEL library #244

Closed pikachu0310 closed 1 month ago

pikachu0310 commented 2 months ago

Provide functionalities similar to Go's net/url using the grpc.federation.url library.

github-actions[bot] commented 2 months ago

Code Metrics Report

main (b948f38) #244 (40a5bcf) +/-
Coverage 65.8% 66.0% +0.2%
Code to Test Ratio 1:0.3 1:0.4 +0.0
Test Execution Time 7m29s 7m57s +28s
Details ``` diff | | main (b948f38) | #244 (40a5bcf) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.8% | 66.0% | +0.2% | | Files | 74 | 75 | +1 | | Lines | 12347 | 12544 | +197 | + | Covered | 8123 | 8281 | +158 | + | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 | | Code | 38141 | 38714 | +573 | + | Test | 13210 | 14028 | +818 | - | Test Execution Time | 7m29s | 7m57s | +28s | ```

Code coverage of files in pull request scope (100.0% → 81.9%)

Files Coverage +/-
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/url.go 80.2% +80.2%

Reported by octocov

github-actions[bot] commented 2 months ago

Code Metrics Report

main (b948f38) #244 (e92034d) +/-
Coverage 65.8% 66.0% +0.2%
Code to Test Ratio 1:0.3 1:0.4 +0.0
Test Execution Time 7m29s 7m49s +20s
Details ``` diff | | main (b948f38) | #244 (e92034d) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 65.8% | 66.0% | +0.2% | | Files | 74 | 75 | +1 | | Lines | 12347 | 12544 | +197 | + | Covered | 8123 | 8281 | +158 | + | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 | | Code | 38141 | 38714 | +573 | + | Test | 13210 | 14028 | +818 | - | Test Execution Time | 7m29s | 7m49s | +20s | ```

Code coverage of files in pull request scope (100.0% → 81.9%)

Files Coverage +/-
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/url.go 80.2% +80.2%

Reported by octocov

github-actions[bot] commented 1 month ago

Code Metrics Report

main (e478944) #244 (97324b8) +/-
Coverage 66.0% 66.2% +0.2%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Test Execution Time 7m55s 8m13s +18s
Details ``` diff | | main (e478944) | #244 (97324b8) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 66.0% | 66.2% | +0.2% | | Files | 75 | 76 | +1 | | Lines | 12418 | 12618 | +200 | + | Covered | 8192 | 8349 | +157 | + | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 | | Code | 38524 | 39108 | +584 | + | Test | 13878 | 14692 | +814 | - | Test Execution Time | 7m55s | 8m13s | +18s | ```

Code coverage of files in pull request scope (100.0% → 80.3%)

Files Coverage +/-
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/url.go 78.5% +78.5%

Reported by octocov

pikachu0310 commented 1 month ago

I have addressed ktgw's review comments and resolved the conflicts. Please review it again.

github-actions[bot] commented 1 month ago

Code Metrics Report

main (e478944) #244 (ef8004a) +/-
Coverage 66.0% 66.3% +0.3%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Test Execution Time 7m55s 8m16s +21s
Details ``` diff | | main (e478944) | #244 (ef8004a) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 66.0% | 66.3% | +0.3% | | Files | 75 | 76 | +1 | | Lines | 12418 | 12556 | +138 | + | Covered | 8192 | 8319 | +127 | + | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 | | Code | 38524 | 39016 | +492 | + | Test | 13878 | 14665 | +787 | - | Test Execution Time | 7m55s | 8m16s | +21s | ```

Code coverage of files in pull request scope (100.0% → 92.9%)

Files Coverage +/-
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/url.go 92.0% +92.0%

Reported by octocov

github-actions[bot] commented 1 month ago

Code Metrics Report

main (e478944) #244 (4e0c688) +/-
Coverage 66.0% 66.3% +0.3%
Code to Test Ratio 1:0.4 1:0.4 +0.0
Test Execution Time 7m55s 7m45s -10s
Details ``` diff | | main (e478944) | #244 (4e0c688) | +/- | |---------------------|----------------|----------------|-------| + | Coverage | 66.0% | 66.3% | +0.3% | | Files | 75 | 76 | +1 | | Lines | 12418 | 12557 | +139 | + | Covered | 8192 | 8320 | +128 | + | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 | | Code | 38524 | 39019 | +495 | + | Test | 13878 | 14665 | +787 | + | Test Execution Time | 7m55s | 7m45s | -10s | ```

Code coverage of files in pull request scope (100.0% → 93.0%)

Files Coverage +/-
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/url.go 92.1% +92.1%

Reported by octocov