search

mercari / hcledit

Go package to edit HCL configuration
MIT License
44 stars 13 forks source link

would like to have RawVal to support adding comments as well #123

Closed piggybankwang closed 2 weeks ago

piggybankwang commented 2 months ago

I see the ctyHandler be able to handle comment https://github.com/mercari/hcledit/blob/main/internal/handler/cty.go#L20 we'd like RawHandler for RawVal be able to accept comment as well https://github.com/mercari/hcledit/blob/main/internal/handler/raw.go#L21 thanks i can contribute as well if approved

ryan-ph commented 1 month ago

Sure! Happy to review a pull request for this. Please just request review from me or the other code owners on the PR.

piggybankwang commented 1 month ago

@ryan-ph a quick update here https://github.com/mercari/hcledit/pull/127/files

ryan-ph commented 2 weeks ago

Thanks for the contribution @piggybankwang!