mercari / tfnotify

A CLI command to parse Terraform execution result and notify it to GitHub
MIT License
619 stars 91 forks source link

Support regional (=private pool) Cloud Build #101

Closed KeisukeYamashita closed 2 years ago

KeisukeYamashita commented 2 years ago

WHAT

I have made changes to the link that will be used for {{ .Link }}.

WHY

To support Cloud Build private pools( Ref: https://cloud.google.com/build/docs/private-pools/private-pools-overview).

The Cloud Build build IDs are generated by regions. Thus, if we want to jump to the detail page of the build that ran on private pool, we need to specify the region by ;region=<region>.

The non-private-pool will be global region. Currently, there are no regions specified which will jump to the default global region, that's why it's working. For private pools, the current link that tfnotify posts, it will not lead us to the detail. The GCP will return 404 page 🙏