mercari / tfnotify

A CLI command to parse Terraform execution result and notify it to GitHub
MIT License
619 stars 91 forks source link

Broken private pool Cloud Build build result links #102

Closed KeisukeYamashita closed 2 years ago

KeisukeYamashita commented 2 years ago

WHAT

The private pool (a.k.a private) Cloud Build build links are broken and the GCP will return 404

WHY

Because private pool Cloud Build build result links have ;region=<REGION> in the link like https://console.cloud.google.com/cloud-build/builds/build-id?project=gcp-project-id. Currently implementation doesn't have that, thus it will get considered as global's result link.

Since the Cloud Build build IDs are generated by regions, we need to add ;region=<REGION> for private pool builds. For global regions, we can specify ;region=global.

KeisukeYamashita commented 2 years ago

Raised https://github.com/mercari/tfnotify/pull/101