Enable slack env vars for channel id and bot name

mercari / tfnotify

A CLI command to parse Terraform execution result and notify it to GitHub

MIT License

620 stars 91 forks source link

Enable slack env vars for channel id and bot name #48

Closed ryok-0319 closed 4 years ago

ryok-0319 commented 4 years ago

WHAT

Enable 2 env vars to configure slack channel id and bot name

WHY

Although the template example for slack in README looks like it is possible to configure channel id and bot name via env vars, these 2 env vars are actually not read.

https://github.com/mercari/tfnotify/blob/master/README.md#template-examples

( It might not be necessary to configure these via env vars. Please close this PR then. )

babarot commented 4 years ago

This means "" and ". But having this as environmental variables is LGTM.

babarot commented 4 years ago

Thank you for the contribution!