Open hanks opened 4 years ago
This PR is spirited by #11, but it is closed, it is a good idea for code review, so I try to make this happen again. Thank you for your time.
@dtan4 @b4b4r07 Hi, would you be able to check this PR at your earliest convenience, thank you for your time.
Thank you for the contribution! This is really nice, please wait a bit more to be reviewed..!
Code seems good. But actually it didn't work well. I tested this it in local but no action part was not shown.
@b4b4r07 Thanks for the comment! Since it is a very old PR, and introduced many complicated from last master branch, so I did a rebase and solved the conflicts.
May I ask a question: How to test in local? Like I use terraform plan | tfnotify --config=.tfnotify.yaml plan
, and added some fmt.Println
for the debug, but I can not see any output from the terminal.
I would want to use this feature. Is there any plan to progress?
WHAT
Extract the action part of terraform plan, to help us to focus on the more important part during code review.
WHY
Sometimes we found the part about
Refreshing Terraform state in-memory prior to plan
has too many lines that we do not need to care about in the code review. So make this change can help us to focus on the action part that terraform plan is.DEMO
The
Action
part will be content below: