We skip generating HPA recommendations if the current replica number is equal to the maximumMaxReplica
because HPA recommendation would be not valid in this case
and, either way, editing HPA would not change any situation because the replica number is already at the maximum.
But, in such cases, we still update VPA recommendations because VPA recommendations are not affected by the replica number
and hopefully making the container bigger would help the situation.
What this PR does / why we need it:
We skip generating HPA recommendations if the current replica number is equal to the maximumMaxReplica because HPA recommendation would be not valid in this case and, either way, editing HPA would not change any situation because the replica number is already at the maximum.
But, in such cases, we still update VPA recommendations because VPA recommendations are not affected by the replica number and hopefully making the container bigger would help the situation.
Which issue(s) this PR fixes:
Fixes #292
Special notes for your reviewer: