search

mercedes-benz / mo360-ftk

MO360 Frontend Toolkit: A toolkit for single page applications (SPA) based on React and Typescript that allows to extract single features into microfrontends.
https://mercedes-benz.github.io/mo360-ftk/
MIT License
70 stars 20 forks source link

Adjust styles imports #25

Closed prode81 closed 3 years ago

prode81 commented 3 years ago

I'm not sure, if this is really necessary, as the core exports everything from styles by default, but I ran into an issue, where makeStyles could occasionally not be found in the exposed material-ui bundle. Fixes #21

This should fix this issue.

Acting on behalf of Daimler TSS GmbH.

prode81 commented 3 years ago

Not sure if this is the cleanest solutions.

Me neither. I will test a little bit further, if this changes really are necessary.

prode81 commented 3 years ago

I did some testing and this issue did not occur anymore.

I now get a warning, that

It looks like there are several instances of @material-ui/styles initialized in this application.

but only at the first hot-replacement within the hostapp after server startup.

But good enough for a dev-setup for swidget-development, so I will discard this PR.