mercedes-benz / odxtools

odxtools is a collection of utilities to interact with the diagnostic functionality of automotive electronic control units using python
MIT License
171 stars 70 forks source link

improve detection of overlapping parameters while encoding #297

Closed andlaus closed 4 months ago

andlaus commented 4 months ago

this functionality is now hopefully bullet-proof: instead of complaining only if at least of the bits which are supposed to be set by a parameter in the coded message is already set, used bits are now explicitly tracked via a bit mask in the EncodeState. As a result, if e.g. an all-zero integer parameter overrides another all-zero integer parameter we will now get an overlapping objects warning as we are supposed to.

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information