mercedes-benz / odxtools

odxtools is a collection of utilities to interact with the diagnostic functionality of automotive electronic control units using python
MIT License
171 stars 70 forks source link

Multiplexer coding fixes #318

Closed andlaus closed 2 months ago

andlaus commented 2 months ago

This PR fixes the en- and decoding routines of multiplexers. The mistake was that we assumed that multiplexer.byte_position specifies the start position of the whole multiplexer object while in reality it only specifies the position of its content part.

Besides this, the PR contains a few smaller quality-of-life improvements:

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information

andlaus commented 2 months ago

okay, I added a unit test for this functionality (I had to fix up a few mistakes in test_diag_data_dictionary_spec first) and rebased it on top of #319...

andlaus commented 2 months ago

@kayoub5: do you see any hurdles for merging this?

kayoub5 commented 1 month ago

@andlaus could you publish a new version with this change?

andlaus commented 1 month ago

done