Closed andlaus closed 2 months ago
okay, I added a unit test for this functionality (I had to fix up a few mistakes in test_diag_data_dictionary_spec
first) and rebased it on top of #319...
@kayoub5: do you see any hurdles for merging this?
@andlaus could you publish a new version with this change?
done
This PR fixes the en- and decoding routines of multiplexers. The mistake was that we assumed that
multiplexer.byte_position
specifies the start position of the whole multiplexer object while in reality it only specifies the position of its content part.Besides this, the PR contains a few smaller quality-of-life improvements:
DiagLayer.decode()
now re-raises encounteredDecodeError
s if the binary data is also not decodable as a global negative response. The old behavior accidentally was to never raiseDecodeError
.MultiplexerCase
object in addition to the short name of the selected caseAndreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information