search

mercedes-benz / odxtools

odxtools is a collection of utilities to interact with the diagnostic functionality of automotive electronic control units using python
MIT License
171 stars 70 forks source link

refactor `DiagLayer` into a class hierarchy #326

Closed andlaus closed 1 month ago

andlaus commented 1 month ago

Instead of a single class for all types of diagnostic layers, ODX specifies a hierarchy of types: ECU shared datas, protocols, functional groups, base variants and ECU variants where all but ECU shared data layers derive from a "hierarchy element" to indicate that these may be a member of a inheritance hierarchy defined using PARENT-REFs. This patch implements this approach.

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information

andlaus commented 1 month ago

@kayoub5: do you consider this ready to be merged? (after merging this, I'll do an v8.0 release.)

andlaus commented 1 month ago

@kayoub5: if no new issues crop up until then, I'll merge this PR on Thursday or Friday...

kayoub5 commented 1 month ago

@kayoub5: if no new issues crop up until then, I'll merge this PR on Thursday or Friday...

I am on the beach, with little access to the pc, I believe I already reviewed most of this PR.

If I find issues later, I will create hotfix PRs.

andlaus commented 1 month ago

great, thanks. Let's get this merged. (have a nice vacation :))