SDGs: if the SDG caption is referenced, do not add its IDs to the odxlink database

mercedes-benz / odxtools

odxtools is a collection of utilities to interact with the diagnostic functionality of automotive electronic control units using python

MIT License

171 stars 70 forks source link

SDGs: if the SDG caption is referenced, do not add its IDs to the odxlink database #328

Closed andlaus closed 1 month ago

andlaus commented 1 month ago

This prevents these SDG captions to be added multiple times (i.e., for SDGs which only reference the caption but do not define it). Under normal circumstances, this only results in slightly lower performance, but in special situations like having to modify a database, it can lead to SDG captions added which are defined nowhere. (I recently stumbled over such a case.)

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH. Provider Information

andlaus commented 1 month ago

I think this is trivial and "objectively correct" enough that there is no need to bother @kayoub5 with a review. @kayoub5: If you would like to have some changes to this, I'll do them in a separate PR...