IdenticalCompuMethod instance in the createanycompumethod.create_any_compu_method_from_et function is missing three required arguments

mercedes-benz / odxtools

odxtools is a collection of utilities to interact with the diagnostic functionality of automotive electronic control units using python

MIT License

171 stars 70 forks source link

IdenticalCompuMethod instance in the createanycompumethod.create_any_compu_method_from_et function is missing three required arguments #331

Closed nada-ben-ali closed 1 week ago

nada-ben-ali commented 3 weeks ago

The IdenticalCompuMethod instance in the createanycompumethod.create_any_compu_method_from_et function is missing three required positional arguments: 'category', 'compu_internal_to_phys', and 'compu_phys_to_internal'.

odxtools version: 7.3.0

kayoub5 commented 2 weeks ago

@andlaus FYI

andlaus commented 2 weeks ago

okay, this is a bug that must be fixed (I'll do so tomorrow). That said, this code is only excuted if the compu method in question is not known (most likely because it is not implemented. there still are a few of them in odxtools). Can you find out what kind of compu method is featured by your dataset? (i.e. what are the the contents of the CATEGORY subtag?)

nada-ben-ali commented 2 weeks ago

@andlaus the compu category is SCALE-RAT-FUNC.

andlaus commented 2 weeks ago

ok, thanks. I suppose I should put some effort into implementing the remaining compu methods. BTW: SCALE-RAT-FUNC is a bit weird IMO because it is not invertible, i.e. encoding a parameter which uses such a transfer function is going to be "fun"...