mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
263 stars 63 forks source link

Mapping configuration concept #129

Closed de-jcup closed 4 years ago

de-jcup commented 4 years ago

Usecase

As an administrator I want to change my ScanConfig by a rest call at administration domain. All running instances of sechub shall be synched and use this configuration

Situation

With #127 we introduced a way to configure scan behavours. This was done by @Value injection. This is okay as first attempt, but we need to restart server to have changes.

Also we got restrictions about configuration sizes (e.g. on Linux 128KB, see https://unix.stackexchange.com/questions/336934/raise-128kib-limit-on-environment-variables-in-linux )

Wanted solution

de-jcup commented 4 years ago

With a look at #2 we must handle this carefully and consider configuration in big picture.

When having a web UI (#11 ) we need REST operations able to to handle actions like in next mockup: image

Because we create an own backend application for #11 we are not forced to handle each operation as necessary for mock ui - but it's okay to make REST calls not too different/difficult...

Domain: Administration

Domain: Scan

Shared kernel:

de-jcup commented 4 years ago

Developer admin UI

To provide this as simple as possible inside developer admin UI, we will provide

de-jcup commented 4 years ago

We let administrators add also additional mappings (custom identifiers) no restrictions at the moment. A delete will also not be implemented this time. If somebody has accidently added a new mapping it can be reset to an empty value (means empty mapping data entity).

de-jcup commented 4 years ago

From main menu calling "->Adapter->Checkmarx" an adapter dialog appears, where mappings for adapter can be customized at runtime:

image