mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
259 stars 61 forks source link

Developer Admin UI shall have always a "Are you sure ?" confirmation #157

Closed de-jcup closed 4 years ago

de-jcup commented 4 years ago

As long as we have no dedicated WebUI (see #11 ) we use the Developer Admin UI for operations. But using this developer tool at production... at least a "Are you sure ?" confirmation for any action shall appear before executed.

There shall be also the possibility to define a system property sechub.developertools.admin.confim (like done for sechub.developertools.admin.environment ). If this property is false than no confirmation shall be shown! (To help developers to reduce this step on non-productive environments were it doesn't mateter)

Classes of interest:

de-jcup commented 4 years ago

@Jeeppler please use/create a feature branch as described at https://github.com/Daimler/sechub/wiki/Collaboration

de-jcup commented 4 years ago

Hmm.. may idea is too too much generic and we should simply go over each action and add an confirmation explicit there - reduces "magic effect" to developers looking at the action and wondering why the confirmation always appears...

Also in some cases it just not make sense - e.g. an action like "list users" needs no confirmation.

@Jeeppler Please just do following