search

mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
259 stars 61 forks source link

Sechub CLI exits prematurly zipping directory withour error on erroneous paths #219

Closed Kaipirinha closed 4 years ago

Kaipirinha commented 4 years ago

Issue/Reproduction: Configuring some SRC paths for SAST Scan as follows

      "folders": [
        "codebase/base/base/src",
        "codebase/media-service/media-service/src", **--> erroneous path**
        "codebase/auth-proxy/auth-proxy/src",
        "codebase/cloudfront-decryption-proxy/cloudfront-decryption-proxy/src",
        "codebase/cloudfront-signed-url-generator/cloudfront-signed-url-generator/src",
        "codebase/config-server/config-server/src",
        "codebase/lambda/elastic-transcoder-lambda-function/src",
        "codebase/ldds-service/ldds-service/src",
        "codebase/media-importer/media-importer/src",
        "codebase/plan-generation/plan-generation/src",
        "codebase/player/backend/src",
        "codebase/player-client/electron/src",
        "codebase/player-client/chrome-app",
        "codebase/player-client/nwjs/src",
        "codebase/player-frontend/frontend/src",
        "codebase/player-manager/backend/src",
        "codebase/rcps-frontend/frontend/src",
        "codebase/reporting-service/reporting-service/src",
        "codebase/ui-backend/backend/src",
        "codebase/thumbnail-generator/thumbnail-generator/src"
      ]

For example, the second entry is somehow wrong. In my case, i forgot a subdirectory. Means its just not there as stateted. Zipping and further analyzing is skipped for all other paths as well.

2020/05/06 07:34:34 Zipping folder: /sechub/codebase/base/base/src
 _____           _   _       _     
/  ___|         | | | |     | |    
\ `--.  ___  ___| |_| |_   _| |__  
 `--. \/ _ \/ __|  _  | | | | '_ \ 
/\__/ /  __/ (__| | | | |_| | |_) |
\____/ \___|\___\_| |_/\__,_|_.__/ Client Version 0.18.0-b72
- Creating new sechub job
- Uploading source zip file

Expected Behaviour: Erroneous path is just skipped proceeding with the other paths and error should be printed.

sven-dmlr commented 4 years ago

Added error handling (which was missing)

Having an invalid folder in your sechub.json now looks like this:

 _____           _   _       _     
/  ___|         | | | |     | |    
\ `--.  ___  ___| |_| |_   _| |__  
 `--. \/ _ \/ __|  _  | | | | '_ \ 
/\__/ /  __/ (__| | | | |_| | |_) |
\____/ \___|\___\_| |_/\__,_|_.__/ Client Version 0.0.0-a5e96c6-dirty-latest
- Creating new sechub job
2020/06/10 11:00:18 Zipping folder: sechub-cli/src (/home/developer/git/sechub-oss/sechub-cli/src)
Folder not found: invalid-folder (/home/developer/git/sechub-oss/invalid-folder)
Exiting due to fatal error...