mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
259 stars 58 forks source link

pds-solutions: remove redundancy in base image definition #2502

Open sven-dmlr opened 10 months ago

sven-dmlr commented 10 months ago

Situation

Currently each pds solution contains an env file containing this line:

BASE_IMAGE="ghcr.io/mercedes-benz/sechub/pds-base"

This redundancy should be removed.

ToDo

sven-dmlr commented 10 months ago

Checked in detail and found out that in the gh-action the BASE_IMAGE variable is not taken from env file:

export BASE_IMAGE="${ACTIONS_SECHUB_REGISTRY}/pds-base:${PDS_VERSION}"

So we can safely remove the above code.

sven-dmlr commented 10 months ago

This issue needs more testing and probably follow-up changes. See comment https://github.com/mercedes-benz/sechub/pull/2517#pullrequestreview-1593827384

-> Somebody else can work on this issue.