Improve remote Data validator

[lorriborri]

Situation

1. The Sechub model validator allows multiple remote sections that can be configured and remote and file system can be configured both at once.

2. The sechub validator does not check the remote data section for correct configuration.

Wanted

1. Check only one configuration
   • When using a remote data section it is only possible to define ONE binary or ONE source definition. Means also: It is only possible to define ONE remote data section (see example 1 for wrong configuration).

• When using a remote data section it is not possible to define any file system (see example 2 for wrong configuration).

2. Check if remote configuration is correct
   • make sure location is not null or blank

• make sure credentials are configured correctly or not defined

Details

example 1: duplicated remote sources (forbidden)

{
  "apiVersion": "1.0",
  "data": {
    "sources": [
      {
        "name": "remote_example_name",
        "remote": {
          "location": "remote_example_location",
          "type": "git",
          "credentials": {
            "user": {
              "name": "my-example-user",
              "password": "my-example-password"
            }
          }
        }
      },
      {
       "name": "remote_example_name_two",
       "remote": {
         "location": "remote_example_location",
         "type": "some-other-type",
         "credentials": {
           "user": {
             "name": "my-example-user",
             "password": "my-example-password"
           }
         }
       }
      }
    ]
  },
  "codeScan": {
    "use": [
      "remote_example_name"
    ]
  }
}

example 2: mix remote and file system (forbidden)

{
  "apiVersion": "1.0",
  "data": {
    "sources": [
      {
        "name": "remote_example_name",
        "remote": {
          "location": "remote_example_location",
          "type": "git",
          "credentials": {
            "user": {
              "name": "my-example-user",
              "password": "my-example-password"
            }
          }
        }
      },
      {
      "name": "filesystem_example",
        "fileSystem" : {
          "folders" : [ "myProject/build" ]
        }
      }
    ]
  },
  "codeScan": {
    "use": [
      "remote_example_name"
    ]
  }
}

Solution

Implement Validation in SechubConfigurationModelValidator