mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
258 stars 58 forks source link

Transfer PDS_STORAGE variables to prepare wrapper application #3176

Closed lorriborri closed 3 weeks ago

lorriborri commented 1 month ago

Situaton

The prepare wrapper application needs access to variables defined in PDSStorageConstants because it needs access to the shared storage to upload remote data.

Wanted

PDSExecutionCallable should put the PDS_STORAGE variables as environment variables to the process builder, but only when PREPARE is the Scantype

Solution

Implement a component that only hosts the PDS_STORAGE variables and has a function createStorageMap to create a map of all PDS_STORAGE variables. The PDSExecutionEnvironmentService should autowire the component and call the createStorageMap function and add the PDS_STORAGE variables to the return map, when the ScanType is PREPARE.

de-jcup commented 4 weeks ago

When I created and implemented #3142 I had the idea to handle it different for scan type PREPARE. But I decided to NOT do this.

Main reasons were:

3142 is already implemented and merged to develop branch and works.

IMO we should close this issue.