mercedes-benz / sechub

SecHub provides a central API to test software with different security tools.
https://mercedes-benz.github.io/sechub/
MIT License
259 stars 58 forks source link

Wrong test behavior of PDSUseSecHubCentralMappingInJobScenario16IntTest on local IDE execution #3222

Closed de-jcup closed 2 weeks ago

de-jcup commented 2 weeks ago

Situation

We test inside PDSUseSecHubCentralMappingInJobScenario16IntTest that the white list entries for reduced script environment variable inheritance work as expected.

But when the integration test PDS server is started from an IDE and not from the gradle scripts, ,the test cannot be executed, because the variables to inherit are not defined.

Currently pds_script_does_have_the_mappings_from_sechub_injected_as_environment_variables ist just skipped in this case and an error log message is done - but the test is green.

This is extreme irritating (at least for myself and I wrote this test... :flushed: )

Wanted

Throw an exception with an info about the problem. The details shall be described still in the log output in detail, but the exception shall also show the necessary configuration of the wanted environment variables.

de-jcup commented 2 weeks ago

Is done with

https://github.com/mercedes-benz/sechub/commit/2fc629d909c6da88387f9b5cd02ee180cfdc4936#diff-9506b523590eab82270f46c033f16d9049b5aedecf3746e1f460abf2e3bd3934