search

merces / libpe

The PE library used by @merces/pev
http://pev.sf.net
GNU Lesser General Public License v3.0
115 stars 40 forks source link

Sort Makefile inputs to make build reproducible #37

Closed davidpolverari closed 3 years ago

davidpolverari commented 3 years ago

Some Linux distributions (such as Debian [1]) are striving to make their build reproducible.

The usage of filesystem globbing as an input to the make build might cause inconsistencies due to differences between locales [2]. This inconsistent behavior prevents reproducible builds.

This patch sorts the Makefile inputs to ensure they will be always processed in the same order [3], contributing to the build system reproducibility.

[1] https://wiki.debian.org/ReproducibleBuilds [2] https://reproducible-builds.org/docs/stable-inputs/#fn:sorted-wildcard [3] https://reproducible-builds.org/docs/stable-inputs/

merces commented 3 years ago

Thanks a lot!