search

mercs600 / vue2-perfect-scrollbar

Vue.js wrapper for perfect scrollbar
https://mercs600.github.io/vue2-perfect-scrollbar/
MIT License
275 stars 43 forks source link

depends on latest perfect-scrollbar ? #15

Closed rogerleung0411 closed 4 years ago

rogerleung0411 commented 4 years ago

here's my situation: I'm using vue2-perfect-scrollbar in my project, but found event listeners were not binding correctly in windows devices with touch screen. I noticed that perfect-scrollbar has fixed this but no one publish the new one to npm. However, this wrapper depends on perfect-scrollbar, what should i do ?

If I create a new repo, fork the latest perfect-scrollbar, build , and publish to npm, and do the same thing to vue2-perfect-scrollbar, do i break the license ? @mercs600

mercs600 commented 4 years ago

@z3rog could you just create PR to my repository with upgraded perfect-scrollbar dependency ? License of this repository is MIT so you can do what you want ;-)

mercs600 commented 4 years ago

@z3rog Sorry, I don't get you right first time. Generally mdbootstrap should merge these PR. I would like to support official perfect-scrollbar repository as dependnecy.

What in case when you just use my wrapper with official dependency and replace perfect-scrollbar dependency (for your fork) in your package.json - does it make sense ?

example package.json:

    "vue2-perfect-scrollbar": "^1.2.3",
    "perfect-scrollbar": "git+https://github.com/tibineagu/perfect-scrollbar.git#custom-classes"
mercs600 commented 4 years ago

@z3rog I close this issue, my last comment should be helpful.