search

mercs600 / vue2-perfect-scrollbar

Vue.js wrapper for perfect scrollbar
https://mercs600.github.io/vue2-perfect-scrollbar/
MIT License
275 stars 43 forks source link

Remove `watchOptions` prop #33

Open WofWca opened 4 years ago

WofWca commented 4 years ago

And just always watch options instead.

  1. The API is unintuitive, and unnecessary. Users can just create a non-reactive options object by themselves.
  2. This prop also almost doubles the size of the package (if we don't count perfect-scrollbar itself
mercs600 commented 4 years ago

Hi, thank you for proposition. I'm wondering what gives you reactive options when you have to reinitialize perfect scrollbar instance again ? PS instance is not reactive itself, so I have to destroy and create new one. What do you think ?

WofWca commented 4 years ago

I'm wondering what gives you reactive options when you have to reinitialize perfect scrollbar instance again ?

Sorry, could you rephrase?

mercs600 commented 4 years ago

Ok never mind, I did not understand you the first time -) So you want it to watch options by default ?

WofWca commented 4 years ago

Yes.

mercs600 commented 4 years ago

I will take into account, because it will be breaking change