mercure-imaging / mercure

mercure DICOM Orchestrator
https://mercure-imaging.org
MIT License
66 stars 32 forks source link

containerize #6

Closed dmd closed 3 years ago

dmd commented 3 years ago

I think it would be a really good idea to containerize; it would take setup from "90% likely to go wrong" to "cannot go wrong".

If I get some time, I'll work on it - hard to justify the time for myself now that I have Hermes working just fine.

Some of what would have to happen:

joshy commented 3 years ago

Definitely agree that a containerized version would be easier to install and use. I am not sure if there needs to be 6 different containers. Why not start with one container which contains everything?

Open / unclear

dmd commented 3 years ago

I've generally been under the impression that there should be one top-level running process per container

RobertFischer commented 3 years ago

Nope: one function per container. You can have as many top-level processes as you want, although you have to watch out for the PID 1 problem. https://github.com/phusion/baseimage-docker#docker_single_process

tblock79 commented 3 years ago

The new version adds support for containers (it can still run without containers)