Open jonnydgreen opened 6 months ago
No clue tbh, this seems a bug between tap and Node.js. Updating this to latest tap (or to node:test`) would fix it
No clue tbh, this seems a bug between tap and Node.js. Updating this to latest tap (or to node:test`) would fix it
Okay, I'll have a play! I did upgrade tap to the latest but the test still failed - I'll open a PR to investigate further :)
When running the tests against the latest commit on
main
with Node.js 20.x, I get the following error for the following test:Test:
Error:
After some debugging and a quick look at the code, it seems like the issue is with the following line: https://github.com/mercurius-js/auth/blob/main/lib/filter-schema.js#L16
Gracefully handling the error by logging out instead seems to solve the issue whilst still preserving the integrity of the test:
wdyt?
I'll get a PR up for this tomorrow, let me know if you think of any other/better suggestions on the solution :)